Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-7211: Update Smoke Test Pipeline Synthetic CCLF #854

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

laurenkrugen-navapbc
Copy link
Contributor

@laurenkrugen-navapbc laurenkrugen-navapbc commented Jun 27, 2023

🎫 Ticket

https://jira.cms.gov/browse/BCDA-7211

🛠 Changes

adding synthetic data for PACA test aco that will be refreshed during smoke test pipeline run.

ℹ️ Context for reviewers

smoke test pipeline fails for the PACA test aco because of stale CCLF data that was added manually a little over a month ago.

✅ Acceptance Validation

(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@laurenkrugen-navapbc laurenkrugen-navapbc marked this pull request as ready for review June 28, 2023 00:13
Copy link
Contributor

@kyeah kyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the successful dev smoke tests. great job getting everything set up correctly and in record time 😄

@laurenkrugen-navapbc
Copy link
Contributor Author

LGTM with the successful dev smoke tests. great job getting everything set up correctly and in record time 😄

thank you! Getting a lot more familiar with these pipelines now..

@laurenkrugen-navapbc laurenkrugen-navapbc merged commit 08157ea into master Jun 28, 2023
@laurenkrugen-navapbc laurenkrugen-navapbc deleted the lauren/BCDA-7211 branch June 28, 2023 15:17
laurenkrugen-navapbc added a commit that referenced this pull request Jul 11, 2023
## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-7211

## 🛠 Changes

adding synthetic data for PACA test aco that will be refreshed during
smoke test pipeline run.

## ℹ️ Context for reviewers

smoke test pipeline fails for the PACA test aco because of stale CCLF
data that was added manually a little over a month ago.

## ✅ Acceptance Validation

Tested with manual runs of smoke test pipeline.

## 🔒 Security Implications

- [ ] This PR adds a new software dependency or dependencies.
- [ ] This PR modifies or invalidates one or more of our security
controls.
- [ ] This PR stores or transmits data that was not stored or
transmitted before.
- [ ] This PR requires additional review of its security implications
for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username:
StewGoin) as a reviewer and do not merge this PR without his approval.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.10%. Comparing base (ff3bbd0) to head (c15be22).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage   75.05%   75.10%   +0.05%     
==========================================
  Files          90       90              
  Lines       10401    10401              
==========================================
+ Hits         7806     7812       +6     
+ Misses       1987     1983       -4     
+ Partials      608      606       -2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3bbd0...c15be22. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants